Now let's make a distinction here between the elected lawmakers and the people they represent.
I have no question in my mind that if you lean Liberal/Democratic you think Trump is bad for you and if you Lean Conservative/Republican you think he is good for you.
That is really not the question. I am talking about the selfish interest of the lawmakers themselves (e.g. wanting to be elected).
Hear me out. Impeachment, if successful would likely energize republican core while at the same time, perhaps errode the Democractic base by apathy. Furthermore, the guy that comes after trump (Pence) would likely be far more successful at passing republican laws than Trump as he is far more cunning and less disorganized. Democratic lawmakers would not really get a victory even if Trump was impeached, instead both senate and WH would still be held by a very R wing conservative, this time with a very energized base. Meanwhile the Democratic base, would be at risk of attrition by apathy.
Instead, I believe that democratic Lawmakers see the potential advantage that Trump brings them into this situation. Government is likely going to be at a gridlock for the next 2 years regardless and the risk of more conservative judges will exist regardless of whether it is pence or trump (though with trump, he is far more likely to nominate a Judge that is controversial and could, in theory, be denied confirmation. I believe that Pence, being more cunning, would more likely do better homework and nominate judges that are just as conservative but less controversial). So, it is my opinion that Trump is actually more valuable to Democratic Lawmakers in the house than impeached. He is the reason for the blue wave, and if the trend continues and he is not impeached, im certain that he won't get elected in 2020 and Republicans will likely lose the senate as well..
In the other hand. I think Trump is worth more impeached for Republican lawmakers (and again, notice the distinction here between lawmakers/elected officials vs supporters). Why? because an impeached Trump is a martyr for his supporters to rally for and would energize them to the core while at the same time would make Democrats more apathetic and lazy (after all, they just layered the big dragon).
I think lawmakers have seized on this and they won't try to do anything fancy. They will probably drag this for another 2 years on purpose just to make Trump progressively more erratic. They will probably keep big secrets and embarrassing information until the very end and make a big reveal at the end as a form of checkmate to win the election.